Skip to content

all: Move provisioning domain variable to fragments, Add placeholder validation, improve rsync dest #72

Merged
marcelmamula merged 2 commits into
sap-linuxlab:devfrom
marcelmamula:update3
Jun 20, 2025
Merged

all: Move provisioning domain variable to fragments, Add placeholder validation, improve rsync dest #72
marcelmamula merged 2 commits into
sap-linuxlab:devfrom
marcelmamula:update3

Conversation

@marcelmamula
Copy link
Copy Markdown
Collaborator

Changes

  1. Add validation for variables containing placeholder values to fail playbook before it proceeds with using them.
  2. Move sap_vm_provision_dns_root_domain to platform fragment vars to ensure it does not trigger placeholder check when running for existing_hosts
  3. Update RSYNC dest regex to ensure it is always pointing towards directory.
  4. Move up sap_software_product into key variables to ensure improved visibility for users
  5. Fix onehost > sandbox product directiory definition

@marcelmamula marcelmamula self-assigned this Jun 19, 2025
@marcelmamula marcelmamula added the enhancement New feature or request label Jun 19, 2025
Copy link
Copy Markdown
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@marcelmamula marcelmamula merged commit 2f8768a into sap-linuxlab:dev Jun 20, 2025
1 check passed
@marcelmamula marcelmamula deleted the update3 branch August 6, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants