Skip to content

Comments

Paint it black#251

Merged
santoshphilip merged 3 commits intosantoshphilip:developfrom
jamiebull1:paint_it_black
Aug 3, 2019
Merged

Paint it black#251
santoshphilip merged 3 commits intosantoshphilip:developfrom
jamiebull1:paint_it_black

Conversation

@jamiebull1
Copy link
Collaborator

Run black on the whole codebase.
Added black --check . to the Travis config for Python 3.7 on linux for master and non-master branches, to fail if formatting inconsistencies are found.

@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@d0525ae). Click here to learn what that means.
The diff coverage is 40.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #251   +/-   ##
==========================================
  Coverage           ?   43.34%           
==========================================
  Files              ?       89           
  Lines              ?     7556           
  Branches           ?        0           
==========================================
  Hits               ?     3275           
  Misses             ?     4281           
  Partials           ?        0
Impacted Files Coverage Δ
eppy/tests/geometry_tests/test_volume_zone.py 0% <ø> (ø)
eppy/tests/test_bunchhelpers.py 0% <ø> (ø)
eppy/geometry/area_zone.py 100% <ø> (ø)
...ts/EPlusInterfaceFunctions_tests/test_parse_idd.py 0% <ø> (ø)
eppy/tests/test_idfreader.py 0% <ø> (ø)
eppy/iddcurrent.py 100% <ø> (ø)
eppy/geometry/mcve.py 0% <ø> (ø)
eppy/tests/test_IDF.py 0% <ø> (ø)
eppy/idf_msequence.py 87.17% <ø> (ø)
eppy/snippet.py 100% <ø> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0525ae...030276f. Read the comment docs.

@santoshphilip
Copy link
Owner

@jamiebull1 , I am going to delay this merge by a week - mostly because I am busy, distracted by another project.
please remind me if nothing happens beyond a week :-)

@santoshphilip
Copy link
Owner

  • I had never used black before. I just knew about it.
  • I tried it on a small project I was working on. Very pleased with the results.
  • I am going to go ahead and merge.

Good call on bringing this into eppy

@santoshphilip santoshphilip merged commit 025e3b8 into santoshphilip:develop Aug 3, 2019
@santoshphilip
Copy link
Owner

I think I should add a contributor documentation with some steps like:

before pushing to GitHub do the following

  • run py.test
  • black ./

Do we have any "how to contribute" documentation in eppy ?
A quick look thru did not find any

@jamiebull1
Copy link
Collaborator Author

I seem to remember we worked on some contribution documentation before. It probably needs updating, and possibly merging if it never got that far.

@jamiebull1
Copy link
Collaborator Author

Here it is #86

@jamiebull1 jamiebull1 deleted the paint_it_black branch August 5, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants