electron-12 #50
Merged
electron-12 #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means at least node 12.17 & electron 11
…king store implementation We have to ensure that we do not pass the same memory multiple times to JS. This is done by using a `map` of memory already passed to JS. This lead to improving the `NativeMemory` API and making it more safe. Published native memory is pooled now and only reference counted handles to it are accessed.
…up the SynchronizationContext and TaskScheduler whenever on a JS only thread.
…fter the context closes.
…ntext to prevent memory leaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for Electron 12.
Major changes:
coreclr-hostingfrom working properlyapp.allowRendererProcessReusebeing fixed to true on Electron 12. This required makingcoreclr-hostingcontext aware and implement proper re-use of the hosted CLR.Known Issues:
ThreadSafeFunctiondoes not get invoked.Code cleanup and small memory management improvements.