fix(performance): improve useArrayProp memoization
#1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the principles detailed in this thread: facebook/react#31330 (comment)
While at it I cleaned up
useArrayProp, which internally seems to never actually usedefaultValue. Since the hook is exported I've added a compat hook insrc/core/hooks/useArrayPropLegacy.tsso that third party libraries that make use of theuseArrayProp(value, defaultValue)pattern continue working.They'll get a deprecated warning though and tell them to migrate to
useArrayProp(value ?? defaultValue).This PR also takes care of the linter warning for
useUniqueinsidesrc/core/utils/portal/portalProvider.tsx