Remove setuptools as a runtime dependency#3138
Open
daniel7an wants to merge 1 commit intosanic-org:mainfrom
Open
Remove setuptools as a runtime dependency#3138daniel7an wants to merge 1 commit intosanic-org:mainfrom
daniel7an wants to merge 1 commit intosanic-org:mainfrom
Conversation
setuptools is only needed at build time, not at runtime. The sanic package code does not import setuptools or pkg_resources anywhere, so there is no reason to include it in install_requires. It is already correctly listed as a build dependency in pyproject.toml. Closes sanic-org#3133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
setuptoolsfrominstall_requiresinsetup.py. It is a build-time dependency only and should not be required at runtime.The sanic package source code does not import
setuptoolsorpkg_resourcesanywhere. It is already correctly declared as a build dependency inpyproject.toml.Closes #3133