-
-
Notifications
You must be signed in to change notification settings - Fork 20
replace Monoid dependency with Alternative dependency for ‘filterM’ #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/List.js
Outdated
| Z.concat(f(this.head), Z.chain(f, this.tail)); | ||
| }; | ||
|
|
||
| List.prototype[FL.alt] = function(other) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In haskell alt for List is concat:
instance Alternative [] where
empty = []
(<|>) = (++)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I find this counter-intuitive, so I tend to forget. Thanks for the reminder. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though, both of the implementations will conform to Alternative laws
safareli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛱
|
We maybe need to relax the constraint, instead of Alternative, we can just take Plus constraint. List can implements Plus, but it can't implements Alternative, as it violate the distribute laws of Alternative as Fantasy Land defined. Because |
|
@syaiful6 for Array for example: const x = [1]
const f = [a => a+1]
const g = [a => a*3]
f.alt(g) = [a => a+1, a => a*3]
x.ap(f.alt(g)) = [(a => a+1)(1), (a => a*3)(1)]
x.ap(f.alt(g)) = [2, 3]
x.ap(f) = [2]
x.ap(g) = [3]
x.ap(f).alt(x.ap(g)) = alt([2], [3]) = [2,3] i.e. List is valid Alternative when |
|
ah, correct.. |
|
I modified Irakli's example to convince myself that the equivalence is not limited to singleton lists: > ([(+ 1),(+ 9)] <|> [(* 3),(* 9)]) <*> [1,2,3]
[2,3,4,10,11,12,3,6,9,9,18,27]
> [(+ 1),(+ 9)] <*> [1,2,3] <|> [(* 3),(* 9)] <*> [1,2,3]
[2,3,4,10,11,12,3,6,9,9,18,27] |
5b19a45 to
fa4df43
Compare
fa4df43 to
46b53ff
Compare
It became apparent in sanctuary-js/sanctuary#359 that
Z.filterM(odd, Just(4))is invalid due to theMonoid (m a)constraint.Just(4)cannot satisfy this constraint as it cannot satisfy the requirements of Semigroup.Just(4)can, though, satisfy the requirements of Alternative.This will allow
S.filterMto operate on values of typeMaybe aeven with type checking enabled.