Skip to content

fix(typia): avoid panic on qualified JSDoc parameter names #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samchon wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(typia): avoid panic on qualified JSDoc parameter names #1861

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be1002c
fix(typia): avoid panic on qualified JSDoc parameter names
samchon May 19, 2026
7cd34b2
publish next version
samchon May 19, 2026
32441fd
fix(typia): inline QualifiedName handling for JSDoc parameter names
samchon May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/typia/native/core/factories/internal/metadata/MetadataHelper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,13 @@ func metadata_js_doc_parameter_name(tag *nativeast.Node) string {
if tag.Kind.String() != "KindJSDocParameterTag" && tag.Kind.String() != "KindJSDocPropertyTag" {
Comment thread
samchon marked this conversation as resolved.
return ""
}
name := tag.AsJSDocParameterOrPropertyTag().Name()
if name == nil {
return ""
}
return name.Text()
// `name` is a DeclarationName: typically an Identifier, but for nested
// JSDoc parameter names like `@param obj.field description` the parser
// produces a QualifiedName, and upstream's (*Node).Text() panics with
// `Unhandled case in Node.Text: *ast.QualifiedName` if we call .Text()
// directly. NodeText in the ttsc shim covers QualifiedName and any
// other DeclarationName Kind that upstream's switch doesn't.
return nativeast.NodeText(tag.AsJSDocParameterOrPropertyTag().Name())
}

func metadata_js_doc_type_expression_text(tag *nativeast.Node) string {
Expand Down
Loading