fix(unplugin): fixed hot reloading in Bun (clone of #1834 for go-lang)#1838
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Bun-specific @typia/unplugin integration to load source files via Bun’s module loader (dynamic import() with type: "text") instead of reading them directly with Bun.file().text(), aiming to improve compatibility with Bun’s loader system and hot reloading behavior.
Changes:
- Replaced
Bun.file(id).text()with a dynamic import using Bun’stextloader in thebuild.onLoadhandler.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+131
to
+133
| const source = wrap<Source>( | ||
| (await import(`${args.path}?`, { with: { type: "text" } })).default, | ||
| ); |
Comment on lines
+131
to
+133
| const source = wrap<Source>( | ||
| (await import(`${args.path}?`, { with: { type: "text" } })).default, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way source files are loaded in the
bunTypiaPluginfor Bun. Instead of usingBun.file().text(), it now loads the file as a module with a text loader, which can improve compatibility and reliability with Bun's module system.Build process improvements:
build.onLoadhandler ofbunTypiaPluginto use dynamic import with{ with: { type: "text" } }instead ofBun.file().text(), ensuring better integration with Bun's loader system.