Skip to content

Write source mapping files even if they already exist. #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielsjoberg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Write source mapping files even if they already exist. #149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57c4e38
Write source mapping files even if they already exist.
gabrielsjoberg Jul 28, 2017
25194b9
Use Java 1.7 API.
gabrielsjoberg Jul 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/main/java/com/samaxes/maven/minify/plugin/ProcessJSFilesTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@

import java.io.*;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -153,9 +155,7 @@ protected void minify(File mergedFile, File minifiedFile) throws IOException {
log.info("Creating the minified file map ["
+ (verbose ? sourceMapResult.getPath() : sourceMapResult.getName()) + "].");

if (sourceMapResult.createNewFile()) {
flushSourceMap(sourceMapResult, minifiedFile.getName(), compiler.getSourceMap());

if (flushSourceMap(sourceMapResult, minifiedFile.getName(), compiler.getSourceMap())) {
writer.append(System.getProperty("line.separator"));
writer.append("//# sourceMappingURL=").append(sourceMapResult.getName());
}
Expand Down Expand Up @@ -184,12 +184,14 @@ protected void minify(File mergedFile, File minifiedFile) throws IOException {
logCompressionGains(mergedFile, minifiedFile);
}

private void flushSourceMap(File sourceMapOutputFile, String minifyFileName, SourceMap sourceMap) {
try (FileWriter out = new FileWriter(sourceMapOutputFile)) {
private boolean flushSourceMap(File sourceMapOutputFile, String minifyFileName, SourceMap sourceMap) {
try (BufferedWriter out = Files.newBufferedWriter(sourceMapOutputFile.toPath(), StandardCharsets.UTF_8)) {
sourceMap.appendTo(out, minifyFileName);
return true;
} catch (IOException e) {
log.error("Failed to write the JavaScript Source Map file ["
+ (verbose ? sourceMapOutputFile.getPath() : sourceMapOutputFile.getName()) + "].", e);
return false;
}
}
}