Skip to content

ci(yamllint): add rule empty-values & use new yaml-files setting#18

Merged
aboe76 merged 1 commit intosaltstack-formulas:masterfrom
myii:chore/standardise-structure
Sep 12, 2019
Merged

ci(yamllint): add rule empty-values & use new yaml-files setting#18
aboe76 merged 1 commit intosaltstack-formulas:masterfrom
myii:chore/standardise-structure

Conversation

@myii
Copy link
Contributor

@myii myii commented Sep 10, 2019

prometheus-formula$ yamllint -s .
./pillar.example
  78:25     error    empty value in block mapping  (empty-values)

@myii myii changed the title ci(yamllint): add rule empty-values & use new yaml-files setting WIP: ci(yamllint): add rule empty-values & use new yaml-files setting Sep 10, 2019
@myii
Copy link
Contributor Author

myii commented Sep 10, 2019

Need to fix before merging:

        yamllint:
          rules:
            empty-values:
              ignore:
                - pillar.example

* Semi-automated using myii/ssf-formula#27
* Fix errors shown below:

```bash
prometheus-formula$ yamllint -s .
./pillar.example
  78:25     error    empty value in block mapping  (empty-values)
```
@myii myii force-pushed the chore/standardise-structure branch from ec7058e to 1784b34 Compare September 10, 2019 21:33
@myii myii changed the title WIP: ci(yamllint): add rule empty-values & use new yaml-files setting ci(yamllint): add rule empty-values & use new yaml-files setting Sep 10, 2019
@myii
Copy link
Contributor Author

myii commented Sep 10, 2019

Fixed as shown in the updated first comment.

@aboe76 aboe76 merged commit f13ab6f into saltstack-formulas:master Sep 12, 2019
@myii
Copy link
Contributor Author

myii commented Sep 13, 2019

Thanks for all of the merges, @aboe76.

@saltstack-formulas-travis

🎉 This PR is included in version 3.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants