ci(yamllint): add rule empty-values & use new yaml-files setting#121
Merged
aboe76 merged 1 commit intosaltstack-formulas:masterfrom Sep 12, 2019
Merged
Conversation
myii
changed the title
empty-values & use new yaml-files settingempty-values & use new yaml-files setting
Contributor
Author
|
Need to fix before merging: yamllint:
rules:
empty-values:
ignore:
- openvpn/defaults.yaml
- pillar.example |
* Semi-automated using myii/ssf-formula#27 * Fix errors shown below: ```bash openvpn-formula$ yamllint -s . ./pillar.example 81:23 error empty value in block mapping (empty-values) 83:16 error empty value in block mapping (empty-values) 114:21 error empty value in block mapping (empty-values) 117:20 error empty value in block mapping (empty-values) 124:21 error empty value in block mapping (empty-values) 151:19 error empty value in block mapping (empty-values) 152:19 error empty value in block mapping (empty-values) 166:14 error empty value in block mapping (empty-values) 169:21 error empty value in block mapping (empty-values) 172:31 error empty value in block mapping (empty-values) 212:14 error empty value in block mapping (empty-values) 214:16 error empty value in block mapping (empty-values) 219:21 error empty value in block mapping (empty-values) 220:29 error empty value in block mapping (empty-values) 221:14 error empty value in block mapping (empty-values) 224:19 error empty value in block mapping (empty-values) 225:19 error empty value in block mapping (empty-values) 226:24 error empty value in block mapping (empty-values) 228:28 error empty value in block mapping (empty-values) 285:15 error empty value in block mapping (empty-values) 286:12 error empty value in block mapping (empty-values) 287:18 error empty value in block mapping (empty-values) 296:20 error empty value in block mapping (empty-values) ./openvpn/defaults.yaml 14:12 error empty value in block mapping (empty-values) ```
myii
force-pushed
the
chore/standardise-structure
branch
from
3c0a44f to
a437b3b
Compare
myii
changed the title
empty-values & use new yaml-files settingempty-values & use new yaml-files setting
Contributor
Author
|
Fixed as shown in the updated first comment. |
|
🎉 This PR is included in version 0.15.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
empty-values& use newyaml-filessetting myii/ssf-formula#27