Expose the input query Id with cycle_initial
#1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #1015 will not alter performanceComparing Summary
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Hmm, the panics from the failed merge queue test run look concerning. I doubt they're related to this change but they suggest that query results can "leak" before the cycle completes. But I haven't been able to reproduce this locally |
mtshiba
added a commit
to mtshiba/ruff
that referenced
this pull request
Oct 29, 2025
mtshiba
added a commit
to mtshiba/salsa
that referenced
this pull request
Oct 29, 2025
mtshiba
added a commit
to mtshiba/salsa
that referenced
this pull request
Oct 29, 2025
mtshiba
added a commit
to mtshiba/salsa
that referenced
this pull request
Oct 29, 2025
mtshiba
added a commit
to mtshiba/salsa
that referenced
this pull request
Oct 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
…#1015 (#1016) * doc: Explain the motivation for breaking API changes made in #1012 and #1015 * Update book/src/cycles.md --------- Co-authored-by: Micha Reiser <[email protected]>
MichaReiser
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Oct 29, 2025
dcreager
added a commit
to astral-sh/ruff
that referenced
this pull request
Oct 30, 2025
* origin/main: (21 commits) [ty] Update "constraint implication" relation to work on constraints between two typevars (#21068) [`flake8-type-checking`] Fix `TC003` false positive with `future-annotations` (#21125) [ty] Fix lookup of `__new__` on instances (#21147) Fix syntax error false positive on nested alternative patterns (#21104) [`pyupgrade`] Fix false positive for `TypeVar` with default on Python <3.13 (`UP046`,`UP047`) (#21045) [ty] Reachability and narrowing for enum methods (#21130) [ty] Use `range` instead of custom `IntIterable` (#21138) [`ruff`] Add support for additional eager conversion patterns (`RUF065`) (#20657) [`ruff-ecosystem`] Fix CLI crash on Python 3.14 (#21092) [ty] Infer type of `self` for decorated methods and properties (#21123) [`flake8-bandit`] Fix correct example for `S308` (#21128) [ty] Dont provide goto definition for definitions which are not reexported in builtins (#21127) [`airflow`] warning `airflow....DAG.create_dagrun` has been removed (`AIR301`) (#21093) [ty] follow the breaking API changes made in salsa-rs/salsa#1015 (#21117) [ty] Rename `Type::into_nominal_instance` (#21124) [ty] Filter out "unimported" from the current module [ty] Add evaluation test for auto-import including symbols in current module [ty] Refactor `ty_ide` completion tests [ty] Render `import <...>` in completions when "label details" isn't supported [`refurb`] Preserve digit separators in `Decimal` constructor (`FURB157`) (#20588) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cycle_fnfunction receives asalsa::Id(from #1012), but in this PR we'll make it so that thecycle_initialfunction can also receive it.This PR contains breaking API changes.
For context on this PR, see astral-sh/ruff#20566 (comment).