Skip to content

Fix keyboard navigation when using menu dropdown with multiple option #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
interactivellama merged 1 commit into from
Jul 3, 2023
Merged

Fix keyboard navigation when using menu dropdown with multiple option #3122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions components/menu-dropdown/__tests__/dropdown.browser-test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,21 @@ describe('SLDSMenuDropdown', function () {
);
expect(firstNode).attr('role', 'menuitemcheckbox');
});

it('moves focus to next item after keyboard selection', function () {
const nodes = getNodes({ wrapper: this.wrapper });
nodes.trigger.simulate('click', {});
const openNodes = getNodes({ wrapper: this.wrapper });
openNodes.menu.simulate('keyDown', keyObjects.DOWN);
openNodes.menu.simulate('keyDown', keyObjects.ENTER);
openNodes.menu.simulate('keyDown', keyObjects.DOWN);
openNodes.menu.simulate('keyDown', keyObjects.ENTER);

const secondNode = openNodes.menu.find('.slds-dropdown__item a').at(1);
expect(secondNode.getDOMNode().getAttribute('aria-checked')).to.not.equal(
'true'
);
});
});

// Hover and hybrid hover UX patterns are not approved UX patterns due to accessibility concerns
Expand Down
5 changes: 4 additions & 1 deletion components/menu-dropdown/menu-dropdown.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,10 @@ class MenuDropdown extends React.Component {

// This is a bit of an anti-pattern, but it has the upside of being a nice default. Component authors can always override to only set state and do their own focusing in their subcomponents.
handleKeyboardFocus = (focusedIndex) => {
if (this.state.focusedIndex !== focusedIndex) {
if (
this.state.focusedIndex !== focusedIndex &&
focusedIndex !== undefined
) {
this.setState({ focusedIndex });
}

Expand Down