+ [feature] supports the enum/in can use object to transform value#67
+ [feature] supports the enum/in can use object to transform value#67snowyu wants to merge 2 commits intosailshq:masterfrom
Conversation
|
this PR needed too: validatorjs/validator.js#336 |
|
Looks like he merged the PR on validator so can you can update this and remove the override? Also in the |
|
the Author merged the PR partly: test the key whether in an object only, instead of the key and value testing. But the Anchor.match.type() passes the value and type arguments only, no additional rule information passed. So once the Maybe you have a good idea for this. I think may be some other types(required the whole rule infomation) need this testType helper function too. To keep compatibility I have to add the isRule argument. To get rid of isRule argument, maybe should I test the type whether is object and the object hasOwnProperty 'type'? but it would not work if type object can have the "type" property too. |
see https://github.com/balderdashy/waterline/issues/52