-
Notifications
You must be signed in to change notification settings - Fork 81
Add support for windows arm64 #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So, the wheel build workflow builds correctly however, there seems to be an odd error for both Windows 3.13 test workflows (both x64 and arm64) and I don't believe it is related to my changes here as I ran the tests on the master branch in my fork and got the same error again for x64 windows without any changes. Specifically, if you look at the logs they both seem to be due to something seemingly building for free-threaded python despite this not being a free-threaded build? And it only happens in the build step for the tests workflow, not the wheel build workflow, I'm guessing due to the wheel build using CIBuildWheel to build rather than running arm64 error: |
|
Very weird! @bdraco do you have any ideas? |
|
Can you please rebase? I've added a fix which pins the Python version on Windows to 3.13.3 which doesn't have the bug. |
Sure thing! |
|
I started the CI. |
This would add wheel builds and run tests for arm64 Windows.
Closes #232