-
-
Notifications
You must be signed in to change notification settings - Fork 691
fix is_free method for new version Singular #41138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Adjust handling of mres to account for trailing zero module in Singular.
Refactor the resolution length check to remove try-except block.
|
Documentation preview for this PR (built with commit 9ba1fc8; changes) is ready! 🎉 |
|
@jhpalmieri - this should be also fixing some of the doctests errors you report with Homebrew Singular, could you have a look? |
|
I unfortunately still get doctest failures with this (and I think the same doctest failures — no change in behavior). |
It is just fix the is_free method. there are many function changes break the doctests. First, check the version of Singular you used is 4.4.1p4 or other version larger than 4.4.1 p1 If it returns True. Then this patch fixed the issue |
|
Expanding on my earlier comment: compared to the issue reported at #40873, this fixes two doctest failures: in |
|
I don't think this way is to fix these discrepancies is sustainable. We should not try to test tests just outputting particular strings, when different strings are just different notation for the same thing. |
but this problem is not simple string issue. It directly cause if you use newer singular It will output False instead of True. It is a wrong output. It is must be fixed. @dimpase |
Since the Singular 4.4.1p4 treat the zero element as the lastest element of free resolution. So we need to check the lastest term is zero or not. And someone may use the system's singular. Like the Ubuntu package is 4.4.1p3. It also has the problem.
📝 Checklist
⌛ Dependencies