Skip to content

Conversation

@cxzhong
Copy link
Contributor

@cxzhong cxzhong commented Nov 5, 2025

Since the Singular 4.4.1p4 treat the zero element as the lastest element of free resolution. So we need to check the lastest term is zero or not. And someone may use the system's singular. Like the Ubuntu package is 4.4.1p3. It also has the problem.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Adjust handling of mres to account for trailing zero module in Singular.
Refactor the resolution length check to remove try-except block.
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Documentation preview for this PR (built with commit 9ba1fc8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@cxzhong cxzhong requested a review from dimpase November 6, 2025 06:09
@dimpase
Copy link
Member

dimpase commented Nov 6, 2025

@jhpalmieri - this should be also fixing some of the doctests errors you report with Homebrew Singular, could you have a look?

@jhpalmieri
Copy link
Member

I unfortunately still get doctest failures with this (and I think the same doctest failures — no change in behavior).

@cxzhong
Copy link
Contributor Author

cxzhong commented Nov 7, 2025

I unfortunately still get doctest failures with this (and I think the same doctest failures — no change in behavior).

It is just fix the is_free method. there are many function changes break the doctests. First, check the version of Singular you used is 4.4.1p4 or other version larger than 4.4.1 p1
Can you run

sage: a = hyperplane_arrangements.IshB(2)
sage: a.cone().is_free()

If it returns True. Then this patch fixed the issue

@jhpalmieri
Copy link
Member

Expanding on my earlier comment: compared to the issue reported at #40873, this fixes two doctest failures: in geometry/hyperplane_arrangement/arrangement.py and in geometry/hyperplane_arrangement/library.py. Other failures remain.

@dimpase
Copy link
Member

dimpase commented Nov 8, 2025

I don't think this way is to fix these discrepancies is sustainable.

We should not try to test tests just outputting particular strings, when different strings are just different notation for the same thing.

@cxzhong
Copy link
Contributor Author

cxzhong commented Nov 8, 2025

We should not try to test tests just outputting particular strings, when different strings are just different notation for the same thing.

but this problem is not simple string issue. It directly cause if you use newer singular It will output False instead of True. It is a wrong output. It is must be fixed. @dimpase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants