slightly restructure the logic of first_terms, to avoid copying when calling a statistic #41119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calling a statistic
|
Documentation preview for this PR (built with commit b412a48; changes) is ready! 🎉 |
Member
|
@mantepse - can you have a look at this? |
Member
|
Oh, sorry, it's your PR :-) |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 21, 2025
sagemathgh-41119: slightly restructure the logic of first_terms, to avoid copying when calling a statistic Currently, calling a statistic copies the dict of known terms. To avoid this, we create a new lazy attribute, for internal use. URL: sagemath#41119 Reported by: Martin Rubey Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 26, 2025
sagemathgh-41119: slightly restructure the logic of first_terms, to avoid copying when calling a statistic Currently, calling a statistic copies the dict of known terms. To avoid this, we create a new lazy attribute, for internal use. URL: sagemath#41119 Reported by: Martin Rubey Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 1, 2025
sagemathgh-41119: slightly restructure the logic of first_terms, to avoid copying when calling a statistic Currently, calling a statistic copies the dict of known terms. To avoid this, we create a new lazy attribute, for internal use. URL: sagemath#41119 Reported by: Martin Rubey Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, calling a statistic copies the dict of known terms. To avoid this, we create a new lazy attribute, for internal use.