Upgrade to flint-3.3.1 #40259
Merged
Upgrade to flint-3.3.1 #40259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
|
eclib needs patching too (builds fine but crashes at runtime) JohnCremona/eclib#87 |
|
Documentation preview for this PR (built with commit 048c572; changes) is ready! 🎉 |
vbraun
force-pushed
the
update-flint-3.3.0
branch
from
bb2f8f8 to
71228c8
Compare
vbraun
force-pushed
the
update-flint-3.3.0
branch
from
71228c8 to
4966f07
Compare
Member
Author
|
This PR now works for me, but doesn't fix #40253 when using gcc 15 |
Member
I will shortly be merging @antonio-rojas 's eclib patch there, so either that patch needs to applied in Sage, or I canmake a new eclib release which Sage will need to use and make as a prerequisite for this PR. Sorry about this, there was a backwards-incompatible change in FLINT. |
Member
Author
|
The eclib patch is already in this PR, fyi |
Contributor
Any idea why? I got the same result, built but segfault. |
Member
Author
|
We've narrowed the segfault down to flint miscompiling with gcc 15, see flintlib/flint#2340 for details |
Flint miscompiles with gcc 15, workaround is to compile with -fno-strict-aliasing This is also what Fedora does: https://src.fedoraproject.org/rpms/flint/blob/rawhide/f/flint.spec#_97-98 See flintlib/flint#2340 for upstream bug report
Contributor
|
It works for me! |
Member
Author
|
I've added the -fno-strict-aliasing to the cflags, but I still get Though not sure if its related to flint, might be another gcc 15 issue. Afaik thats just using pari so no flint involved... |
Contributor
That's a random issue, I've beed getting it occasionally for a long time |
Member
Author
|
Ah true, using different random seed "fixes" the two descent ;) So this PR is ready for review. |
Contributor
|
there's now en eclib release including the patch, and also a 3.3.1 flint bugfix release. |
Member
Author
|
I've updated the patch for flint-3.3.1, though it still segfaults without The new eclib release doesn't build with gcc-14, I've opened JohnCremona/eclib#88 |
vbraun
force-pushed
the
update-flint-3.3.0
branch
from
048c572 to
31faf32
Compare
Member
Author
|
I've upgraded the PR to eclib 20250627, now eclib does not need the flint compatibility patch any more It would be nice to get this reviewed so we can make a release that actually works on Fedora.... |
Contributor
|
I tried this in two computers. In the second one, fresh compilation, everything is fine, only one test did not pass (as in #38544 (comment)); the compilation failed in maxima using system ecl, it worked with the spkg. |
vbraun
force-pushed
the
update-flint-3.3.0
branch
from
31faf32 to
8253d12
Compare
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 7, 2025
Straightforward upgrade to the latest release Apparently Singluar is not yet compatible with it ``` [singular-4.4.1] [spkg-install] /usr/bin/bash ./libtool --tag=CXX --mode=compile g++ -std=gnu++11 -DHAVE_CONFIG_H -I. -I./include -I./include -I. -DFACTORY_BUILDING_DLL -I/home/vbraun/Sage/git/local/var/tmp/sage/build/singular-4.4.1/src -I/home/vbraun/Sage/git/local/var/tmp/sage/build/singular-4.4.1/src -I/home/vbraun/Sage/git/local/include/ -I/home/vbraun/Sage/git/local/include -I/home/vbraun/Sage/git/local/include -DSING_NDEBUG -DOM_NDEBUG -g -O2 -pipe -fno-common -g0 -O3 -Wno-unused-function -Wno-trigraphs -Wno- unused-parameter -Wunknown-pragmas -Wno-unused-variable -fomit-frame- pointer -fwrapv -fvisibility=default -finline-functions -fno-exceptions -fno-threadsafe-statics -fno-enforce-eh-specs -fconserve-space -funroll- loops -fno-rtti -c -o FLINTconvert.lo FLINTconvert.cc [singular-4.4.1] [spkg-install] libtool: compile: g++ -std=gnu++11 -DHAVE_CONFIG_H -I. -I./include -I./include -I. -DFACTORY_BUILDING_DLL -I/home/vbraun/Sage/git/local/var/tmp/sage/build/singular-4.4.1/src -I/home/vbraun/Sage/git/local/var/tmp/sage/build/singular-4.4.1/src -I/home/vbraun/Sage/git/local/include/ -I/home/vbraun/Sage/git/local/include -I/home/vbraun/Sage/git/local/include -DSING_NDEBUG -DOM_NDEBUG -g -O2 -pipe -fno-common -g0 -O3 -Wno-unused-function -Wno-trigraphs -Wno- unused-parameter -Wunknown-pragmas -Wno-unused-variable -fomit-frame- pointer -fwrapv -fvisibility=default -finline-functions -fno-exceptions -fno-threadsafe-statics -fno-enforce-eh-specs -fconserve-space -funroll- loops -fno-rtti -c FLINTconvert.cc -fPIC -DPIC -o .libs/FLINTconvert.o [singular-4.4.1] [spkg-install] FLINTconvert.cc: In function 'void convertFacCFMatrix2Fq_nmod_mat_t(fq_nmod_mat_struct*, const fq_nmod_ctx_struct*, const CFMatrix&)': [singular-4.4.1] [spkg-install] FLINTconvert.cc:655:36: error: 'struct fq_nmod_mat_struct' has no member named 'rows' [singular-4.4.1] [spkg-install] 655 | convertFacCF2nmod_poly_t (M->rows[i-1]+j-1, m (i,j)); [singular-4.4.1] [spkg-install] | ^~~~ [singular-4.4.1] [spkg-install] make[11]: *** [Makefile:1274: FLINTconvert.lo] Error 1 [singular-4.4.1] [spkg-install] make[10]: *** [Makefile:1379: all- recursive] Error 1 [singular-4.4.1] [spkg-install] make[9]: *** [Makefile:1041: all] Error 2 [singular-4.4.1] [spkg-install] make[8]: *** [Makefile:624: all- recursive] Error 1 [singular-4.4.1] [spkg-install] make[7]: *** [Makefile:475: all] Error 2 [singular-4.4.1] [spkg-install] **************************************** ************************************************************************ ***************************************** [singular-4.4.1] [spkg-install] Error building singular-4.4.1 [singular-4.4.1] [spkg-install] **************************************** ************************************************************************ ***************************************** ``` See Singular/Singular#1279 Fixes sagemath#40253 URL: sagemath#40259 Reported by: Volker Braun Reviewer(s):
Member
Author
|
I've bumped the min version in build/pkgs/eclib/spkg-configure.m4 so a working eclib is required Still needs review... |
Member
|
I see no problems, but I'm not sure if I can give a positive review without doing a build from scratch on a machine without lots of versions of FLINT and eclib already installed -- which I do not have. If you don't think that matters, please say so. |
Contributor
|
I built with the last change. Some tests failed with ./sage -t -a but they passed when run independently (Fedora 42) |
Member
Author
|
I ran it on the buildbot and tests pass there... |
Member
Author
|
Just a reminder that this PR is necessary to pass tests on Fedora 42... please review... |
Contributor
|
From my experience it builts in my installations of Fedora 42. Concerning the tests, there were some failures with |
Member
Author
|
this PR should really be uncontroversial, its just upstream updates and collecting a patch that upstream provided to work |
enriqueartal
approved these changes
Jul 19, 2025
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 26, 2025
sagemathgh-40448: Replace ci-linux-incremental by ci-linux <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The incremental runs are supposed to test package updates - however, exactly in those situations, they are not working since the rebuilt sagelib is not linking correctly against the new versions. For example, in the flint update sagemath#40259, we get > [sagemath_doc_html-none] [spkg-install] from sage.rings import complex_interval, integer [sagemath_doc_html-none] [spkg-install] ImportError: libflint.so.20: cannot open shared object file: No such file or directory https://github.com/sagemath/sage/actions/runs/15979364834/job/4507007300 7?pr=40259#step:11:4686 For this reason, the incremental runs are replaced here by the build- from-zero runs. Those are a bit slower but more reliable. ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40448 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 27, 2025
sagemathgh-40448: Replace ci-linux-incremental by ci-linux <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The incremental runs are supposed to test package updates - however, exactly in those situations, they are not working since the rebuilt sagelib is not linking correctly against the new versions. For example, in the flint update sagemath#40259, we get > [sagemath_doc_html-none] [spkg-install] from sage.rings import complex_interval, integer [sagemath_doc_html-none] [spkg-install] ImportError: libflint.so.20: cannot open shared object file: No such file or directory https://github.com/sagemath/sage/actions/runs/15979364834/job/4507007300 7?pr=40259#step:11:4686 For this reason, the incremental runs are replaced here by the build- from-zero runs. Those are a bit slower but more reliable. ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40448 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 28, 2025
sagemathgh-40448: Replace ci-linux-incremental by ci-linux <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The incremental runs are supposed to test package updates - however, exactly in those situations, they are not working since the rebuilt sagelib is not linking correctly against the new versions. For example, in the flint update sagemath#40259, we get > [sagemath_doc_html-none] [spkg-install] from sage.rings import complex_interval, integer [sagemath_doc_html-none] [spkg-install] ImportError: libflint.so.20: cannot open shared object file: No such file or directory https://github.com/sagemath/sage/actions/runs/15979364834/job/4507007300 7?pr=40259#step:11:4686 For this reason, the incremental runs are replaced here by the build- from-zero runs. Those are a bit slower but more reliable. ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40448 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 29, 2025
sagemathgh-40448: Replace ci-linux-incremental by ci-linux <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The incremental runs are supposed to test package updates - however, exactly in those situations, they are not working since the rebuilt sagelib is not linking correctly against the new versions. For example, in the flint update sagemath#40259, we get > [sagemath_doc_html-none] [spkg-install] from sage.rings import complex_interval, integer [sagemath_doc_html-none] [spkg-install] ImportError: libflint.so.20: cannot open shared object file: No such file or directory https://github.com/sagemath/sage/actions/runs/15979364834/job/4507007300 7?pr=40259#step:11:4686 For this reason, the incremental runs are replaced here by the build- from-zero runs. Those are a bit slower but more reliable. ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40448 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 1, 2025
sagemathgh-40448: Replace ci-linux-incremental by ci-linux <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The incremental runs are supposed to test package updates - however, exactly in those situations, they are not working since the rebuilt sagelib is not linking correctly against the new versions. For example, in the flint update sagemath#40259, we get > [sagemath_doc_html-none] [spkg-install] from sage.rings import complex_interval, integer [sagemath_doc_html-none] [spkg-install] ImportError: libflint.so.20: cannot open shared object file: No such file or directory https://github.com/sagemath/sage/actions/runs/15979364834/job/4507007300 7?pr=40259#step:11:4686 For this reason, the incremental runs are replaced here by the build- from-zero runs. Those are a bit slower but more reliable. ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40448 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward upgrade to the latest release
Apparently Singluar is not yet compatible with it
See Singular/Singular#1279
Fixes #40253