Skip to content

Conversation

@Eloitor
Copy link
Contributor

@Eloitor Eloitor commented Jun 9, 2025

Simplify matrix construction in btquotient.py to improve readability.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Documentation preview for this PR (built with commit 81ad425; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor

Hopefully no performance regression caused by column_matrix(). But probably negligible.

@Eloitor
Copy link
Contributor Author

Eloitor commented Jun 29, 2025

I'm generalizing this code for number fields, and simplifying the code will make it easier for me and reviewers

@vbraun vbraun merged commit 78fceb7 into sagemath:develop Jul 6, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants