Implement crt for multivariate polynomials #40117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user202729
commented
May 17, 2025
tscrim
approved these changes
May 19, 2025
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
Some minor comments, otherwise LGTM.
Co-authored-by: Travis Scrimshaw <[email protected]>
Contributor
Author
|
The GitHub Actions can definitely be improved in this case. |
|
Documentation preview for this PR (built with commit 0c58cee; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 4, 2025
sagemathgh-40117: Implement crt for multivariate polynomials Mirroring the method with same name in `Integer` class. Implementation detail: The method `lift` could probably be moved up to `Modules.ElementMethods`, but if we do that it should probably have a better name such as `as_linear_combination`. Possible follow-up: make this work with `CRT_list` free function too. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#40117 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 6, 2025
sagemathgh-40117: Implement crt for multivariate polynomials Mirroring the method with same name in `Integer` class. Implementation detail: The method `lift` could probably be moved up to `Modules.ElementMethods`, but if we do that it should probably have a better name such as `as_linear_combination`. Possible follow-up: make this work with `CRT_list` free function too. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#40117 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 8, 2025
sagemathgh-40117: Implement crt for multivariate polynomials Mirroring the method with same name in `Integer` class. Implementation detail: The method `lift` could probably be moved up to `Modules.ElementMethods`, but if we do that it should probably have a better name such as `as_linear_combination`. Possible follow-up: make this work with `CRT_list` free function too. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#40117 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40117: Implement crt for multivariate polynomials Mirroring the method with same name in `Integer` class. Implementation detail: The method `lift` could probably be moved up to `Modules.ElementMethods`, but if we do that it should probably have a better name such as `as_linear_combination`. Possible follow-up: make this work with `CRT_list` free function too. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#40117 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40117: Implement crt for multivariate polynomials Mirroring the method with same name in `Integer` class. Implementation detail: The method `lift` could probably be moved up to `Modules.ElementMethods`, but if we do that it should probably have a better name such as `as_linear_combination`. Possible follow-up: make this work with `CRT_list` free function too. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#40117 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40117: Implement crt for multivariate polynomials Mirroring the method with same name in `Integer` class. Implementation detail: The method `lift` could probably be moved up to `Modules.ElementMethods`, but if we do that it should probably have a better name such as `as_linear_combination`. Possible follow-up: make this work with `CRT_list` free function too. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#40117 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirroring the method with same name in
Integerclass.Implementation detail: The method
liftcould probably be moved up toModules.ElementMethods, but if we do that it should probably have a better name such asas_linear_combination.Possible follow-up: make this work with
CRT_listfree function too.📝 Checklist