-
-
Notifications
You must be signed in to change notification settings - Fork 704
move tree generation methods to src/sage/graphs/generators/trees.pyx
#39753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Documentation preview for this PR (built with commit 14c12f8; changes) is ready! 🎉 |
acc03d4 to
679065d
Compare
|
I have opened issue #39864 for a random doctest error reported by CI that is not related to this PR: https://github.com/sagemath/sage/actions/runs/14265417106/job/39986034778?pr=39753#step:12:7936 Another random doctest not related to this PR (https://github.com/sagemath/sage/actions/runs/14265417106/job/39986033045?pr=39753#step:12:6259) is fixed in #39837. |
|
@maxale, @DaveWitteMorris: some help reviewing this PR would be much appreciated |
|
@dcoudert Thanks for making the PR. Sorry I have been busy and expect to still be busy for the rest of the month (and the PR has a lot of lines of code), so I don't think I will be able to do this soon. But I will look at it if it still needs review when I have time. |
|
anyone to review this PR ? |
|
I'm sorry, but I've been busy this summer. I have had very little time to spend on sagemath in the past two months, and there are several PRs I should review, but I don't know when I'll be able to get to them. I expect to get to this one eventually if nobody else does it in the meantime. |
|
@fchapoton @tscrim could you help reviewing this PR. |
|
do you see any other issues ? |
fchapoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
|
Thank you |
|
ya un test super long dans les random k-trees qui mérite le tag "# long time", à faire ailleurs.. |
|
je note pour le test. C'est assez curieux car il y a des tests hypers longs sur le CI qui sont très rapides sur nos machines. |
Fixes #39180 .
This PR implements the changes proposed in #39180 (comment):
src/sage/graphs/trees.pyxandsrc/sage/graphs/trees.pxdtosrc/sage/graphs/generators/.graphs.trees(),graphs.nauty_gentreeg(),graphs.BalancedTree(),graphs.FibonacciTree(),graphs.RandomTree(),graphs.RandomTreePowerlaw(),graphs.RandomLobster(), etc.trees.pyx.📝 Checklist
⌛ Dependencies