-
-
Notifications
You must be signed in to change notification settings - Fork 746
adding the ring of quantum-valued polynomials #38952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Documentation preview for this PR (built with commit ee6b71c; changes) is ready! 🎉 |
tscrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This should be the last two things.
Co-authored-by: Travis Scrimshaw <[email protected]>
tscrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM.
|
Well, once the tests all finish and come back (morally) green. |
|
the meson conda failure seems to be related. No idea what this is doing, apparently not seeing the new module. Not the first time I met this issue, see also #38965 |
|
Yea, I usually ignore that since it happens so often... positive review. |
|
You have to add the new file in |
|
Thanks for the fix! |
sagemathgh-38952: adding the ring of quantum-valued polynomials This is a q-analogue of the ring of integer-valued polynomials. The elements are polynomials in x such that their evaluation at every q-integer is a polynomial in q. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#38952 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
sagemathgh-38952: adding the ring of quantum-valued polynomials This is a q-analogue of the ring of integer-valued polynomials. The elements are polynomials in x such that their evaluation at every q-integer is a polynomial in q. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#38952 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
This is a q-analogue of the ring of integer-valued polynomials. The elements are polynomials in x such that their evaluation at every q-integer is a polynomial in q.
📝 Checklist