Skip to content

Conversation

@fchapoton
Copy link
Contributor

This is a q-analogue of the ring of integer-valued polynomials. The elements are polynomials in x such that their evaluation at every q-integer is a polynomial in q.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions
Copy link

github-actions bot commented Nov 10, 2024

Documentation preview for this PR (built with commit ee6b71c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This should be the last two things.

Co-authored-by: Travis Scrimshaw <[email protected]>
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Nov 22, 2024

Well, once the tests all finish and come back (morally) green.

@fchapoton
Copy link
Contributor Author

the meson conda failure seems to be related. No idea what this is doing, apparently not seeing the new module. Not the first time I met this issue, see also #38965

@tscrim
Copy link
Collaborator

tscrim commented Nov 22, 2024

Yea, I usually ignore that since it happens so often... positive review.

@tobiasdiez
Copy link
Contributor

You have to add the new file in src/sage/rings/polynomial/meson.build, either manually or by running tools/update-meson.py.
Sorry, it's on my todo list to add documentation around this and post a bit more details about meson on the mailing list.

@tobiasdiez
Copy link
Contributor

Thanks for the fix!

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 6, 2024
sagemathgh-38952: adding the ring of quantum-valued polynomials
    
This is a q-analogue of the ring of integer-valued polynomials. The
elements are polynomials in x such that their evaluation at every
q-integer is a polynomial in q.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38952
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 8, 2024
sagemathgh-38952: adding the ring of quantum-valued polynomials
    
This is a q-analogue of the ring of integer-valued polynomials. The
elements are polynomials in x such that their evaluation at every
q-integer is a polynomial in q.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38952
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
@vbraun vbraun merged commit 83db192 into sagemath:develop Dec 8, 2024
21 of 22 checks passed
@fchapoton fchapoton deleted the quantum_valued branch December 9, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants