Skip to content

expunge is_commutative from plural #38930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbraun merged 2 commits into from
Nov 16, 2024
Merged

expunge is_commutative from plural #38930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb35d26
expunge is_commutative from plural
fchapoton Nov 5, 2024
f13aa2e
Apply suggestions from code review
fchapoton Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions src/sage/rings/polynomial/plural.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,16 @@ TESTS::
sage: TestSuite(P).run()
sage: loads(dumps(P)) is P
True

sage: A.<x,y,z> = FreeAlgebra(QQ, 3)
sage: P = A.g_algebra(relations={y*x:-x*y}, order = 'lex')
sage: P.is_commutative()
False

sage: R.<x,y,z> = FreeAlgebra(QQ, 3)
sage: P = R.g_algebra(relations={}, order='lex')
sage: P.is_commutative()
True
"""
from cysignals.memory cimport sig_malloc, sig_free

Expand Down Expand Up @@ -676,22 +686,7 @@ cdef class NCPolynomialRing_plural(Ring):
"""
return self._term_order

def is_commutative(self):
"""
Return ``False``.

.. TODO:: Provide a mathematically correct answer.

EXAMPLES::

sage: A.<x,y,z> = FreeAlgebra(QQ, 3)
sage: P = A.g_algebra(relations={y*x:-x*y}, order = 'lex')
sage: P.is_commutative()
False
"""
return False

def is_field(self, *args, **kwargs):
def is_field(self, *args, **kwargs) -> bool:
"""
Return ``False``.

Expand Down
Loading