Graph tikz method fixup#38847
Merged
Merged
Conversation
…in set_options method already
…ise, they get broken...)
5 tasks
dcoudert
reviewed
Oct 24, 2024
Collaborator
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
LGTM, but this branch should be rebased on last beta.
|
Documentation preview for this PR (built with commit 515f3cb; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 26, 2024
tikz method for graphs was recently added in sagemath#38798 default value for `format` should be `None` as documented. ### ⌛ Dependencies sagemath#38798 URL: sagemath#38847 Reported by: Sébastien Labbé Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 5, 2025
sagemathgh-38848: Adding a tikz method to FinitePoset class We add a `tikz` method to the class `FinitePoset` returning a `TikzPicture` instance from `sage.misc.latex_standalone` module. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies It uses the tikz method for graphs added in sagemath#38798 and the follow-up small fix made in sagemath#38847. URL: sagemath#38848 Reported by: Sébastien Labbé Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 6, 2025
sagemathgh-38848: Adding a tikz method to FinitePoset class We add a `tikz` method to the class `FinitePoset` returning a `TikzPicture` instance from `sage.misc.latex_standalone` module. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies It uses the tikz method for graphs added in sagemath#38798 and the follow-up small fix made in sagemath#38847. URL: sagemath#38848 Reported by: Sébastien Labbé Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 9, 2025
sagemathgh-38848: Adding a tikz method to FinitePoset class We add a `tikz` method to the class `FinitePoset` returning a `TikzPicture` instance from `sage.misc.latex_standalone` module. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies It uses the tikz method for graphs added in sagemath#38798 and the follow-up small fix made in sagemath#38847. URL: sagemath#38848 Reported by: Sébastien Labbé Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tikz method for graphs was recently added in #38798
default value for
formatshould beNoneas documented.⌛ Dependencies
#38798