Skip to content

Conversation

@fchapoton
Copy link
Contributor

Using ruff to auto-fix all E713 codes

Test for membership should be not in

then activating this check in the linter

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions
Copy link

github-actions bot commented Oct 8, 2024

Documentation preview for this PR (built with commit 181e960; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Member

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fchapoton
Copy link
Contributor Author

Merci !

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 9, 2024
sagemathgh-38788: Ruff e713
    
Using ruff to auto-fix all E713 codes

Test for membership should be `not in`

then activating this check in the linter

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38788
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 10, 2024
Using ruff to auto-fix all E713 codes

Test for membership should be `not in`

then activating this check in the linter

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

URL: sagemath#38788
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
@vbraun vbraun merged commit 83b30af into sagemath:develop Oct 12, 2024
@fchapoton fchapoton deleted the ruff_E713 branch October 16, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants