Added two missing difference sets, updated URLs #38755
Conversation
|
Documentation preview for this PR (built with commit f711216; changes) is ready! 🎉 |
dimpase
left a comment
dimpase
left a comment
There was a problem hiding this comment.
Nice. Can you perhaps add the info on the groups in the non-cyclic examples?
I added some information. Let me know if that's what you had in mind. |
|
looks good, let's wait for CI to finish. |
dimpase
added
s: positive review
c: combinatorics
c: combinatorial designs
and removed
s: needs review
labels
sagemathgh-38755: Added two missing difference sets, updated URLs <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38755 Reported by: Dan Gordon Reviewer(s): Dima Pasechnik
|
Can anyone shed light on the failed check? codecov says that line 519 isn't covered by a test, but it is, and all that changed was what the url variable was set to; I can't see how that would make the code go from passing to failing the check. Could codecov be wrong? A similar issue came up here: https://github.com/ballerina-platform/ballerina-lang/issues/31348 |
|
codecov is too strict. If it's an innocent place, no need to add a test. |
4 participants
📝 Checklist
⌛ Dependencies