Skip to content

Conversation

@fchapoton
Copy link
Contributor

add some typing annotation in the modified file

also remove one unused import

and some traces of python 2

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions
Copy link

github-actions bot commented Sep 11, 2024

Documentation preview for this PR (built with commit 7fc7e9b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Member

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbraun vbraun merged commit 27fce1f into sagemath:develop Sep 15, 2024
@fchapoton fchapoton deleted the types_in_temporary_file branch September 16, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants