fixing most ruff PERF4 warnings in combinat #38635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 94f80bb; changes) is ready! 🎉 |
mkoeppe
approved these changes
Sep 7, 2024
Contributor
mkoeppe
left a comment
mkoeppe
left a comment
There was a problem hiding this comment.
LGTM. Most of these changes are also welcome improvements of readability of the code.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 8, 2024
this is fixing most suggestions of `ruff check --select=PERF4` in the combinat folder. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38635 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 10, 2024
sagemathgh-38635: fixing most ruff PERF4 warnings in combinat this is fixing most suggestions of `ruff check --select=PERF4` in the combinat folder. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38635 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 12, 2024
sagemathgh-38635: fixing most ruff PERF4 warnings in combinat this is fixing most suggestions of `ruff check --select=PERF4` in the combinat folder. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38635 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is fixing most suggestions of
ruff check --select=PERF4in the combinat folder.📝 Checklist