Skip to content

Conversation

@gmou3
Copy link
Contributor

@gmou3 gmou3 commented Sep 4, 2024

Done to avoid the following warnings:

warning: sage/groups/perm_gps/permgroup_element.pyx:611:33: Assigning to 'UInt2 *' from 'const UInt2 *' discards const qualifier
warning: sage/groups/perm_gps/permgroup_element.pyx:621:33: Assigning to 'UInt4 *' from 'const UInt4 *' discards const qualifier

@github-actions
Copy link

github-actions bot commented Sep 4, 2024

Documentation preview for this PR (built with commit 02f46bf; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 6, 2024
sagemathgh-38615:  `permgroup_element.pyx`: add some `const`s
    
Done to avoid the following warnings:
```
warning: sage/groups/perm_gps/permgroup_element.pyx:611:33: Assigning to
'UInt2 *' from 'const UInt2 *' discards const qualifier
warning: sage/groups/perm_gps/permgroup_element.pyx:621:33: Assigning to
'UInt4 *' from 'const UInt4 *' discards const qualifier
```
    
URL: sagemath#38615
Reported by: gmou3
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 8, 2024
sagemathgh-38615:  `permgroup_element.pyx`: add some `const`s
    
Done to avoid the following warnings:
```
warning: sage/groups/perm_gps/permgroup_element.pyx:611:33: Assigning to
'UInt2 *' from 'const UInt2 *' discards const qualifier
warning: sage/groups/perm_gps/permgroup_element.pyx:621:33: Assigning to
'UInt4 *' from 'const UInt4 *' discards const qualifier
```
    
URL: sagemath#38615
Reported by: gmou3
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 8, 2024
sagemathgh-38615:  `permgroup_element.pyx`: add some `const`s
    
Done to avoid the following warnings:
```
warning: sage/groups/perm_gps/permgroup_element.pyx:611:33: Assigning to
'UInt2 *' from 'const UInt2 *' discards const qualifier
warning: sage/groups/perm_gps/permgroup_element.pyx:621:33: Assigning to
'UInt4 *' from 'const UInt4 *' discards const qualifier
```
    
URL: sagemath#38615
Reported by: gmou3
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 10, 2024
sagemathgh-38615:  `permgroup_element.pyx`: add some `const`s
    
Done to avoid the following warnings:
```
warning: sage/groups/perm_gps/permgroup_element.pyx:611:33: Assigning to
'UInt2 *' from 'const UInt2 *' discards const qualifier
warning: sage/groups/perm_gps/permgroup_element.pyx:621:33: Assigning to
'UInt4 *' from 'const UInt4 *' discards const qualifier
```
    
URL: sagemath#38615
Reported by: gmou3
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 12, 2024
sagemathgh-38615:  `permgroup_element.pyx`: add some `const`s
    
Done to avoid the following warnings:
```
warning: sage/groups/perm_gps/permgroup_element.pyx:611:33: Assigning to
'UInt2 *' from 'const UInt2 *' discards const qualifier
warning: sage/groups/perm_gps/permgroup_element.pyx:621:33: Assigning to
'UInt4 *' from 'const UInt4 *' discards const qualifier
```
    
URL: sagemath#38615
Reported by: gmou3
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 05db5cd into sagemath:develop Sep 15, 2024
@gmou3 gmou3 deleted the permgroup_element_const branch September 16, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants