Skip to content

Conversation

@rburing
Copy link
Contributor

@rburing rburing commented Aug 23, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

None.

@rburing
Copy link
Contributor Author

rburing commented Aug 23, 2024

All the tests passing the Setup Conda environment step (in contrast with other recent PRs) shows that the change works.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 23, 2024

The correct way to do this is to first update build/pkgs/python_build/distros/conda.txt (and then to run tox -e update_conda_lock)

@github-actions
Copy link

github-actions bot commented Aug 23, 2024

Documentation preview for this PR (built with commit b130474; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@rburing
Copy link
Contributor Author

rburing commented Aug 23, 2024

@mkoeppe Should all the unrelated changes resulting from that command be included here as well, or not?

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 23, 2024

The scope of the PR is up to you, but a general update would certainly be welcome. In any case, it would be a good idea to run the full conda platform test by manually invoking the "CI Conda" GH Actions workflow in your fork.

@rburing rburing force-pushed the conda_sed_build_python-build branch from 748ab26 to 0ec3482 Compare August 23, 2024 16:02
@rburing rburing changed the title Fix conda environments after build was removed from conda-forge in favor of python-build Update conda environments after build was removed from conda-forge in favor of python-build Aug 23, 2024
@rburing
Copy link
Contributor Author

rburing commented Aug 23, 2024

@mkoeppe I'll give it a try. The workflow is running.

@rburing rburing force-pushed the conda_sed_build_python-build branch from 0ec3482 to b130474 Compare August 23, 2024 16:32
@rburing rburing changed the title Update conda environments after build was removed from conda-forge in favor of python-build Fix conda environments after build was removed from conda-forge in favor of python-build Aug 23, 2024
@rburing
Copy link
Contributor Author

rburing commented Aug 23, 2024

On second thought (build failures), I would prefer to keep it simple here.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 23, 2024

No problem, a whole bunch of updates are coming in anyway soon that will require us to update the conda-lock files again.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 23, 2024

In any case, it would be a good idea to run the full conda platform test by manually invoking the "CI Conda" GH Actions workflow in your fork.

When there's a successful run, please post a link

@rburing
Copy link
Contributor Author

rburing commented Aug 23, 2024

Here's the current run: https://github.com/rburing/sage/actions/runs/10529188299

I don't see what I can do in this PR to make it succeed, the errors all look unrelated.

@tobiasdiez
Copy link
Contributor

Thanks, LGTM.

The version check fail already since 95428a1 by @mkoeppe. Would be awesome if you could fix it Matthias!

@tobiasdiez tobiasdiez added the p: CI fix merged before running CI tests label Aug 23, 2024
@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 23, 2024

It's a downstream problem.

@tobiasdiez
Copy link
Contributor

It's a downstream problem.

Sure, an unnecessarily strict version constraint is a downstream issue 😄. Let me help you: #38556

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 23, 2024

I'll explain it to you again: The flaw lies in the design of the conda setup, which insists on having suitable conda packages available - which is outside of the scope of the Sage project.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 23, 2024

What you need to do is work with downstream to package the current version of the package.

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 27, 2024
sagemathgh-38554: Fix conda environments after `build` was removed from conda-forge in favor of `python-build`
    
- Fixes sagemath#38550

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

None.
    
URL: sagemath#38554
Reported by: Ricardo Buring
Reviewer(s):
@vbraun vbraun merged commit f1645d8 into sagemath:develop Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: distribution p: CI fix merged before running CI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conda environment files are outdated after build was removed from conda-forge in favor of python-build

4 participants