Skip to content

Conversation

@fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Aug 20, 2024

just a few minor details in the code of the file strassen.pyx

including a wrong float-division by 2

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton marked this pull request as draft August 21, 2024 06:26
@fchapoton fchapoton marked this pull request as ready for review August 21, 2024 15:24
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fchapoton
Copy link
Contributor Author

back to positive after trivial merge

@github-actions
Copy link

github-actions bot commented Sep 4, 2024

Documentation preview for this PR (built with commit 33602cc; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor Author

some strange doctests failures in conda..

@dcoudert
Copy link
Contributor

dcoudert commented Sep 4, 2024

Indeed, but I think it has nothing to do with this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 5, 2024
sagemathgh-38539: some details in strassen.pyx
    
just a few minor details in the code of the file `strassen.pyx`

including a wrong float-division by 2

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38539
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 6, 2024
sagemathgh-38539: some details in strassen.pyx
    
just a few minor details in the code of the file `strassen.pyx`

including a wrong float-division by 2

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38539
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 8, 2024
sagemathgh-38539: some details in strassen.pyx
    
just a few minor details in the code of the file `strassen.pyx`

including a wrong float-division by 2

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38539
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 8, 2024
sagemathgh-38539: some details in strassen.pyx
    
just a few minor details in the code of the file `strassen.pyx`

including a wrong float-division by 2

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38539
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 10, 2024
sagemathgh-38539: some details in strassen.pyx
    
just a few minor details in the code of the file `strassen.pyx`

including a wrong float-division by 2

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38539
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 12, 2024
sagemathgh-38539: some details in strassen.pyx
    
just a few minor details in the code of the file `strassen.pyx`

including a wrong float-division by 2

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38539
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
@vbraun vbraun merged commit c7bbcb4 into sagemath:develop Sep 15, 2024
@fchapoton fchapoton deleted the minor_details_strassen branch September 16, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants