-
-
Notifications
You must be signed in to change notification settings - Fork 711
some details in strassen.pyx #38539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some details in strassen.pyx #38539
Conversation
dcoudert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
back to positive after trivial merge |
|
Documentation preview for this PR (built with commit 33602cc; changes) is ready! 🎉 |
|
some strange doctests failures in conda.. |
|
Indeed, but I think it has nothing to do with this PR. |
sagemathgh-38539: some details in strassen.pyx just a few minor details in the code of the file `strassen.pyx` including a wrong float-division by 2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#38539 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton
sagemathgh-38539: some details in strassen.pyx just a few minor details in the code of the file `strassen.pyx` including a wrong float-division by 2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#38539 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton
sagemathgh-38539: some details in strassen.pyx just a few minor details in the code of the file `strassen.pyx` including a wrong float-division by 2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#38539 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton
sagemathgh-38539: some details in strassen.pyx just a few minor details in the code of the file `strassen.pyx` including a wrong float-division by 2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#38539 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton
sagemathgh-38539: some details in strassen.pyx just a few minor details in the code of the file `strassen.pyx` including a wrong float-division by 2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#38539 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton
sagemathgh-38539: some details in strassen.pyx just a few minor details in the code of the file `strassen.pyx` including a wrong float-division by 2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#38539 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton
just a few minor details in the code of the file
strassen.pyxincluding a wrong float-division by 2
📝 Checklist