Skip to content

Demote jmol to optional #38504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vbraun merged 7 commits into from
Sep 15, 2024
Merged

Demote jmol to optional #38504

vbraun merged 7 commits into from
Sep 15, 2024

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Aug 12, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 4d1c2d7; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@NathanDunfield NathanDunfield self-requested a review August 31, 2024 12:49
NathanDunfield
NathanDunfield approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@NathanDunfield NathanDunfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 31, 2024

Thank you!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 3, 2024

Rebased

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 8, 2024
c4737ab 
sagemathgh-38504: Demote `jmol` to optional
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Resolves sagemath#31027

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38504
Reported by: Matthias Köppe
Reviewer(s): Nathan Dunfield
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 8, 2024
26dc962 
sagemathgh-38504: Demote `jmol` to optional
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Resolves sagemath#31027

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38504
Reported by: Matthias Köppe
Reviewer(s): Nathan Dunfield
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 10, 2024
17bf875 
sagemathgh-38504: Demote `jmol` to optional
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Resolves sagemath#31027

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38504
Reported by: Matthias Köppe
Reviewer(s): Nathan Dunfield
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 12, 2024
4926b6c 
sagemathgh-38504: Demote `jmol` to optional
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Resolves sagemath#31027

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38504
Reported by: Matthias Köppe
Reviewer(s): Nathan Dunfield
@vbraun vbraun merged commit 9a30984 into sagemath:develop Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NathanDunfield NathanDunfield NathanDunfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mkoeppe mkoeppe

Labels

c: graphics c: packages: standard

Projects

None yet

Milestone

sage-10.5

Development

Successfully merging this pull request may close these issues.

Make jmol optional

3 participants

@mkoeppe @NathanDunfield @vbraun