Skip to content

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 21, 2024

Newest versions of Docker buildx give a syntax warning
https://github.com/sagemath/sage/actions/runs/9605919331/job/26494464435?pr=38227#step:13:194

WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 5)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

…Casing: 'as' and 'FROM' keywords' casing do not match
@github-actions
Copy link

github-actions bot commented Jun 21, 2024

Documentation preview for this PR (built with commit b61a9f4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Member

@soehms soehms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM.

Co-authored-by: Sebastian Oehms <[email protected]>
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 21, 2024

Thanks for the fixes; I should have checked the diff.

@soehms soehms requested review from sebastian-oehms and removed request for sebastian-oehms June 21, 2024 19:07
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 21, 2024

Thanks!

@vbraun vbraun merged commit 4263cef into sagemath:develop Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants