Fix typo "sage.ring" in docstrings #38215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct module path is "sage.rings" instead of "sage.ring". In sage/modular/pollack_stevens/padic_lseries.py and in sage/structure/factory.pyx the typo prevents doctests from being run. In sage/rings/polynomial/padics/polynomial_padic.py the typo is merely cosmetic.
saraedum
approved these changes
Jun 13, 2024
|
Documentation preview for this PR (built with commit d08315f; changes) is ready! 🎉 |
Author
|
The failure occurs while running "sage -t --long src/sage/rings/tests.py". Perhaps the timeout failure while testing src/sage/rings/tests.py was just by chance, and a re-run of the test might be successful? |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38215: Fix typo "sage.ring" in docstrings The correct module path is "sage.rings" instead of "sage.ring". In sage/modular/pollack_stevens/padic_lseries.py and in sage/structure/factory.pyx the typo prevents doctests from being run because the "needs" requirement canot be fulfilled. In sage/rings/polynomial/padics/polynomial_padic.py the typo is merely cosmetic. See brief [discussion in Sage Support Group](https://groups.google.com/g/sage-support/c/Msx0QJF7rpA) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> / - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38215 Reported by: Jens-Erik Riedel Reviewer(s): David Coudert, Julian Rüth
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38215: Fix typo "sage.ring" in docstrings The correct module path is "sage.rings" instead of "sage.ring". In sage/modular/pollack_stevens/padic_lseries.py and in sage/structure/factory.pyx the typo prevents doctests from being run because the "needs" requirement canot be fulfilled. In sage/rings/polynomial/padics/polynomial_padic.py the typo is merely cosmetic. See brief [discussion in Sage Support Group](https://groups.google.com/g/sage-support/c/Msx0QJF7rpA) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> / - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38215 Reported by: Jens-Erik Riedel Reviewer(s): David Coudert, Julian Rüth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct module path is "sage.rings" instead of "sage.ring".
In sage/modular/pollack_stevens/padic_lseries.py and in sage/structure/factory.pyx the typo prevents doctests from being run because the "needs" requirement canot be fulfilled.
In sage/rings/polynomial/padics/polynomial_padic.py the typo is merely cosmetic.
See brief discussion in Sage Support Group
📝 Checklist
/
⌛ Dependencies