Column and row stabilizers for skew tableaux #38197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit a9c13b1; changes) is ready! 🎉 |
tscrim
requested changes
Jun 12, 2024
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
Just some minor details.
src/sage/combinat/skew_tableau.py
Outdated
Comment on lines
1154
to
1155
| sage: rs = SkewTableau([[None,1,2,3],[4,5]]).row_stabilizer() | ||
| sage: rs.order() == factorial(3)*factorial(2) |
Collaborator
There was a problem hiding this comment.
Suggested change
| sage: rs = SkewTableau([[None,1,2,3],[4,5]]).row_stabilizer() | |
| sage: rs.order() == factorial(3)*factorial(2) | |
| sage: rs = SkewTableau([[None,1,2,3], [4,5]]).row_stabilizer() | |
| sage: rs.order() == factorial(3) * factorial(2) |
And perhaps similar spacing between the lists. At least, it should be consistent (see the next rs = ... below).
Co-authored-by: Travis Scrimshaw <[email protected]>
tscrim
reviewed
Jun 12, 2024
tscrim
reviewed
Jun 12, 2024
Co-authored-by: Travis Scrimshaw <[email protected]>
tscrim
added
s: positive review
c: combinatorics
c: algebra
t: enhancement
and removed
v: moderate
labels
Contributor
Author
|
Thank you, Travis! |
Contributor
|
Lint failure, please fix |
Contributor
Author
|
Right, good catch. Fixed! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38197: Column and row stabilizers for skew tableaux Row and column stabilizers and the usual a, b, e elements of the symmetric group algebra are now computable for skew standard tableaux, not just for straight ones. The a, b, e functions are still not exposed at class level, but this can be done another day. The performance cost (at least on the e function) is trivial: ``` sage: %timeit eold([[2,3],[1,4]]) 1.29 ms ± 12.7 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each) sage: %timeit enew([[2,3],[1,4]]) 1.29 ms ± 15.5 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each) sage: %timeit eold([[2,3],[1,4],[5,7]]) 3.43 ms ± 141 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) sage: %timeit enew([[2,3],[1,4],[5,7]]) 3.44 ms ± 158 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) ``` (Tested using factored-out code, since the actual functions are cached.) URL: sagemath#38197 Reported by: Darij Grinberg Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38197: Column and row stabilizers for skew tableaux Row and column stabilizers and the usual a, b, e elements of the symmetric group algebra are now computable for skew standard tableaux, not just for straight ones. The a, b, e functions are still not exposed at class level, but this can be done another day. The performance cost (at least on the e function) is trivial: ``` sage: %timeit eold([[2,3],[1,4]]) 1.29 ms ± 12.7 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each) sage: %timeit enew([[2,3],[1,4]]) 1.29 ms ± 15.5 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each) sage: %timeit eold([[2,3],[1,4],[5,7]]) 3.43 ms ± 141 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) sage: %timeit enew([[2,3],[1,4],[5,7]]) 3.44 ms ± 158 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) ``` (Tested using factored-out code, since the actual functions are cached.) URL: sagemath#38197 Reported by: Darij Grinberg Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Row and column stabilizers and the usual a, b, e elements of the symmetric group algebra are now computable for skew standard tableaux, not just for straight ones.
The a, b, e functions are still not exposed at class level, but this can be done another day.
The performance cost (at least on the e function) is trivial:
(Tested using factored-out code, since the actual functions are cached.)