Revert "gh-36678: CI conda: Ignore baseline test failures " #36923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 29901c4; changes) is ready! 🎉 |
Contributor
|
This nonsense really needs to stop. |
Contributor
|
It really doesn't work this way, even if you think that a particular PR should be reverted. |
Contributor
|
This is obviously not a blocker. |
This was referenced Dec 23, 2023
Contributor
|
This PR is not appropriate and is a violation of Sage's code of conduct: directly reverting a PR where you disagree with the community's decision, then giving yourself positive review with a comment that it is a "trivial git revert" is completely unacceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #36678, which was marked as "positive review" although not all reviewer concern had been addressed.
I'll set this directly as "positive review" since this is a trivial git revert.
📝 Checklist
⌛ Dependencies