-
-
Notifications
You must be signed in to change notification settings - Fork 721
sage.groups, sage.rings.number_field: Modularization fixes, # needs
#36865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dcoudert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to list the new file galois_group_perm.py in the right .rst file so that it appear in https://doc.sagemath.org/html/en/reference/groups/index.html ?
otherwise, LGTM.
|
Also |
dcoudert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The addition to the appropriate place in some index.rst file can be done later.
|
Thank you! |
|
rebased |
|
Documentation preview for this PR (built with commit 1d77a49; changes) is ready! 🎉 |
Standard modularization work:
sage.libs.braiding# needsto simplify decorations# needs, in particular forsage.libs.gapsage.groups.galois_grouplazy_importsPart of:
📝 Checklist
⌛ Dependencies