Skip to content

Enable conda ci for all PRs and remove experimental label #36373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbraun merged 2 commits into from
Oct 8, 2023
Merged

Enable conda ci for all PRs and remove experimental label #36373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87fdf66
Enable conda ci for all PRs and remove experimental label
tobiasdiez Oct 1, 2023
e7d0a44
Fail fast for PRs
tobiasdiez Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions .github/workflows/ci-conda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,6 @@ on:
branches:
- 'public/build/**-runci'
pull_request:
types:
# Defaults
- opened
- synchronize
- reopened
# When a CI label is added
- labeled
workflow_dispatch:
# Allow to run manually

Expand All @@ -27,20 +20,9 @@ jobs:
name: Conda
runs-on: ${{ matrix.os }}

# Run on push, workflow dispatch and when certain labels are added or are present
if: |
github.event_name != 'pull_request' ||
((github.event.action != 'labeled' &&
(contains(github.event.pull_request.labels.*.name, 'c: packages: standard') ||
contains(github.event.pull_request.labels.*.name, 'c: packages: optional') ||
contains(github.event.pull_request.labels.*.name, 's: run conda ci'))) ||
(github.event.action == 'labeled' &&
(github.event.label.name == 'c: packages: optional' ||
github.event.label.name == 'c: packages: standard' ||
github.event.label.name == 's: run conda ci')))

strategy:
fail-fast: false
fail-fast: ${{ github.event_name == 'pull_request' }}
max-parallel: ${{ github.event_name == 'pull_request' && 2 || 6 }}
matrix:
os: [ubuntu-latest, macos-latest]
python: ['3.9', '3.10', '3.11']
Expand Down
5 changes: 1 addition & 4 deletions src/doc/en/installation/conda.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,17 +93,14 @@ from source as follows:

.. _sec-installation-conda-develop:

Using conda to provide all dependencies for the Sage library (experimental)
Using conda to provide all dependencies for the Sage library
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

You can build and install the Sage library from source, using conda to
provide all of its dependencies. This bypasses most of the build
system of the Sage distribution and is the fastest way to set up an
environment for Sage development.

Note that this is still an experimental feature and may not work as
intended.

Here we assume that you are using a git checkout.

- Optionally, set the build parallelism for the Sage library. Use
Expand Down