sage.geometry.polyhedron: More # optional - sage.rings.number_field

[mkoeppe]

We also remove some module-level imports of AA etc.

Split out from #32432.

CC: @kliem @jplab @yuan-zhou @sheerluck

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: da3d534

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/34195

[mkoeppe]

Branch: u/mkoeppe/sage_geometry_polyhedron__more___optional___sage_rings_number_field

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1 +1,4 @@
+We also remove some module-level imports of `AA` etc.
 
+Split out from #32432.
+

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

2d1d0e3	Polyhedra_base._repr_base_ring: Factor out from ._repr_ambient_module, do not fail if AA cannot be imported
9a8ff00	src/sage/geometry/polyhedron/parent.py: Mark doctests # optional - sage.rings.number_field
dcbb3b6	sage.geometry: Remove module-level imports of AA, RR, PolynomialRing
f9222ae	sage.geometry: More # optional - sage.rings.number_field

[mkoeppe]

Commit: f9222ae

[sagetrac-git]

Changed commit from f9222ae to 278b93f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9e6b7b2	Polyhedra_base._repr_base_ring: Factor out from ._repr_ambient_module, do not fail if AA cannot be imported
22e4b7c	src/sage/geometry/polyhedron/parent.py: Mark doctests # optional - sage.rings.number_field
2a0c39a	sage.geometry: Remove module-level imports of AA, RR, PolynomialRing
278b93f	sage.geometry: More # optional - sage.rings.number_field

[kliem]

comment:6

Please take care of the pyflakes errors. In particular you removed imports of ZZ, QQ also leading to doctest errors:

+src/sage/geometry/polyhedron/backend_normaliz.py:2480:20 undefined name 'PolynomialRing'
+src/sage/geometry/polyhedron/backend_normaliz.py:2480:35 undefined name 'QQbar'
+src/sage/geometry/polyhedron/backend_normaliz.py:2481:24 undefined name 'PolynomialRing'
+src/sage/geometry/polyhedron/base.py:54:1 'sage.rings.abc' imported but unused
+
+src/sage/geometry/polyhedron/base0.py:1369:36 undefined name 'ZZ'
+src/sage/geometry/polyhedron/base0.py:1369:62 undefined name 'QQ'
+src/sage/geometry/polyhedron/base0.py:1430:36 undefined name 'ZZ'
+src/sage/geometry/polyhedron/base0.py:1430:62 undefined name 'QQ'
+
+src/sage/geometry/polyhedron/base3.py:1865:17 'sage.graphs.graph' imported but unused
+
+src/sage/geometry/polyhedron/base6.py:701:17 'sage.graphs.graph' imported but unused
+
+src/sage/geometry/polyhedron/parent.py:178:13 local variable 'polymake_base_field' is assigned to but never used
+found 11 pyflakes errors in the modified files

[sagetrac-git]

Changed commit from 278b93f to 0f12ac2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0f12ac2

src/sage/geometry/polyhedron/base0.py: Restore lost imports

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

74bc04b	src/sage/geometry/polyhedron/base{3,6}.py: Muffle pyflakes warnings about unused imports
7db47e1	src/sage/geometry/polyhedron/parent.py: Muffle pyflakes warning
6dd4f07	src/sage/geometry/polyhedron/base.py: Remove unused import
1ede214	src/sage/geometry/polyhedron/backend_normaliz.py: Add missing imports
341475c	src/sage/geometry/polyhedron/base_ZZ.py: Replace .all import

[sagetrac-git]

Changed commit from 0f12ac2 to 341475c

[mkoeppe]

comment:9

Thanks, this got damaged in the rebase