sage.rings: Modularization changes

[mkoeppe]

split out from #32432.

CC: @kliem

Component: refactoring

Author: Matthias Koeppe, Jonathan Kliem

Branch/Commit: 92d88c0

Reviewer: Jonathan Kliem, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32870

[mkoeppe]

Branch: u/mkoeppe/sage-rings-modularization

[mkoeppe]

New commits:

bd1e636	src/sage/rings/quotient_ring*.py: Delay imports from sage.interfaces.singular
ead8653	src/sage/rings/finite_rings/finite_field_constructor.py: Do not fail if .finite_field_givaro cannot be imported
f2a2adc	src/sage/rings/rational.pyx: Move import of mathml into method
59e54b0	src/sage/rings/rational.pyx: Do not fail at import time when sage.rings.real_* is not available

[mkoeppe]

Commit: 59e54b0

[mkoeppe]

comment:3

    from .functional import (additive_order,
  File "/srv/public/patchbot-sage/local/lib/python3.7/site-packages/sage/misc/functional.py", line 26, in <module>
    from sage.rings.complex_double import CDF
  File "sage/rings/complex_double.pyx", line 110, in init sage.rings.complex_double (build/cythonized/sage/rings/complex_double.c:24921)
  File "sage/rings/complex_mpfr.pyx", line 1, in init sage.rings.complex_mpfr (build/cythonized/sage/rings/complex_mpfr.c:35629)
  File "sage/rings/real_mpfr.pyx", line 1, in init sage.rings.real_mpfr (build/cythonized/sage/rings/real_mpfr.c:47129)
  File "sage/libs/mpmath/utils.pyx", line 17, in init sage.libs.mpmath.utils (build/cythonized/sage/libs/mpmath/utils.c:9319)
ImportError: cannot import name ComplexField

[sagetrac-git]

Changed commit from 59e54b0 to 8ba0734

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

136de8b	src/sage/rings/rational.pyx: Move import of mathml into method
a4b7c9d	src/sage/rings/finite_rings/finite_field_constructor.py: Do not fail if .finite_field_givaro cannot be imported
8ba0734	src/sage/rings/quotient_ring*.py: Delay imports from sage.interfaces.singular

[mkoeppe]

comment:5

Backed out the last change to src/sage/rings/rational.pyx

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

48cab99	Import Algebra from sage.rings.ring, not sage.algebras.algebra
9f5fd79	Import CommutativeAlgebra from sage.rings.ring, not sage.rings.commutative_algebra
e606d35	src/sage/rings/polynomial/polynomial_ring.py: fixup

[sagetrac-git]

Changed commit from 8ba0734 to e606d35

[mkoeppe]

comment:7

sage -t --long --random-seed=194261639548588837697181034125749346937 src/sage/rings/commutative_algebra.py
**********************************************************************
File "src/sage/rings/commutative_algebra.py", line 28, in sage.rings.commutative_algebra.is_CommutativeAlgebra
Failed example:
    sage.rings.commutative_algebra.is_CommutativeAlgebra(sage.rings.ring.CommutativeAlgebra(ZZ))
Exception raised:
    Traceback (most recent call last):
      File "/srv/public/patchbot-sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 694, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/srv/public/patchbot-sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 1088, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.rings.commutative_algebra.is_CommutativeAlgebra[0]>", line 1, in <module>
        sage.rings.commutative_algebra.is_CommutativeAlgebra(sage.rings.ring.CommutativeAlgebra(ZZ))
    AttributeError: module 'sage.rings' has no attribute 'commutative_algebra'

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

da3c5cf	Merge tag '9.5.beta7' into t/32870/sage-rings-modularization
fba5f43	src/sage/rings/commutative_algebra.py: Fix up imports in doctest

[sagetrac-git]

Changed commit from e606d35 to fba5f43

[kliem]

comment:10

Before:

sage: P.<x,y>  = PolynomialRing(GF(2),2)
sage: I = sage.rings.ideal.FieldIdeal(P)
sage: Q = P.quo(I)
sage: %timeit Q._singular_()
833 ns ± 1.01 ns per loop (mean ± std. dev. of 7 runs, 1000000 loops each)

After:

sage: P.<x,y>  = PolynomialRing(GF(2),2)
sage: I = sage.rings.ideal.FieldIdeal(P)
sage: Q = P.quo(I)
sage: %timeit Q._singular_()
1.37 µs ± 0.777 ns per loop (mean ± std. dev. of 7 runs, 1000000 loops each)

I will see, if I can improve this.

[kliem]

comment:11

Before:

sage: R.<x,y> = PolynomialRing(QQ)
sage: S = R.quotient_ring(x^2+y^2)
sage: %timeit S.ideal(x+y+1)
8.2 µs ± 38.6 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
sage: %timeit S.ideal()
2.24 µs ± 8.11 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
sage: %timeit S(x)
2.04 µs ± 7.01 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

After:

sage: R.<x,y> = PolynomialRing(QQ)
sage: S = R.quotient_ring(x^2+y^2)
sage: %timeit S.ideal(x+y+1)
9.71 µs ± 36.4 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
sage: %timeit S.ideal()
3.2 µs ± 26.5 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
sage: %timeit S(x)
2.75 µs ± 6.89 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

[kliem]

Changed author from Matthias Koeppe to Matthias Koeppe, Jonathan Kliem