sage.rings.{real,complex}_double: Remove compile time dependency on cypari2

[mkoeppe]

... as previously done in #30022 for sage.rings.integer and sage.rings.rational.

This is to support modularization (#29705):

• in particular, for sagemath-categories (Modularization of sagelib: Break out separate packages sagemath-objects, sagemath-categories #29865), to make the functions py_scalar_parent and py_scalar_to_element (from sage.structure.coerce) fully functional without having to pull in PARI (at compile time or run time)
• likewise, for sagemath-polyhedra (Modularization of sagelib: Break out a separate package sagemath-polyhedra #32432) to support floating-point polyhedra and linear programming without having to pull in PARI (at compile time or run time).

CC: @kliem @videlec @tscrim @yyyyx4

Component: refactoring

Author: Matthias Koeppe, Jonathan Kliem

Branch/Commit: 629c319

Reviewer: Matthias Koeppe, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32701

[mkoeppe]

Branch: u/mkoeppe/sage_rings__real_complex__double__remove_compile_time_dependency_on_cypari2

[mkoeppe]

Author: Matthias Koeppe, ...

[mkoeppe]

comment:3

Here's an attempt but I'm getting doctest errors:

sage -t --random-seed=0 src/sage/rings/polynomial/polynomial_element.pyx
      File "sage/rings/complex_double.pyx", line 387, in sage.rings.complex_double.ComplexDoubleField_class._element_constructor_ (build/cythonized/sage/rings/complex_double.c:6109)
        return ComplexDoubleElement(x, 0)
      File "sage/rings/complex_double.pyx", line 755, in sage.rings.complex_double.ComplexDoubleElement.__init__ (build/cythonized/sage/rings/complex_double.c:9194)
        self._complex = gsl_complex_rect(real, imag)
      File "cypari2/gen.pyx", line 2002, in cypari2.gen.Gen.__float__
      File "cypari2/handle_error.pyx", line 213, in cypari2.handle_error._pari_err_handle
    cypari2.handle_error.PariError: incorrect type in gtodouble [t_REAL expected] (t_COMPLEX)

---

New commits:

2cc2fa7	src/sage/rings/real_double.pyx: Replace cimport from cypari.convert by method-local import
d641dc6	src/sage/rings/complex_double.pyx: Move PARI conversion functions to src/sage/libs/pari/

[mkoeppe]

Commit: d641dc6

[kliem]

Changed branch from u/mkoeppe/sage_rings__real_complex__double__remove_compile_time_dependency_on_cypari2 to u/gh-kliem/sage_rings__real_complex__double__remove_compile_time_dependency_on_cypari2

[kliem]

Changed commit from d641dc6 to bc1710c

[kliem]

comment:4

Checking the most obvious thing helped:

sage: from sage.rings.complex_double import pari_gen
sage: pari_gen
()

---

New commits:

e43dfad	Merge branch 'u/mkoeppe/sage_rings__real_complex__double__remove_compile_time_dependency_on_cypari2' of git://trac.sagemath.org/sage into u/gh-kliem/sage_rings__real_complex__double__remove_compile_time_dependency_on_cypari2
bc1710c	fix incorrect import

[kliem]

Changed author from Matthias Koeppe, ... to Matthias Koeppe, Jonathan Kliem

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

71b62be	new_gen_from_double not available as python function
64984be	coverage

[sagetrac-git]

Changed commit from bc1710c to 64984be

[mkoeppe]

comment:7

Thank you! Let's wait for the patchbot

[mkoeppe]

comment:8

Testing locally, I am seeing:

[sagelib-9.5.beta4] warning: sage/libs/pari/convert_sage_complex_double.pxd:4:44: Declarations should not be declared inline.
[sagelib-9.5.beta4] warning: sage/libs/pari/convert_sage_complex_double.pyx:9:6: Function 'pari_to_cdf' previously declared as 'cpdef'

[mkoeppe]

Changed branch from u/gh-kliem/sage_rings__real_complex__double__remove_compile_time_dependency_on_cypari2 to u/mkoeppe/sage_rings__real_complex__double__remove_compile_time_dependency_on_cypari2

[mkoeppe]

Reviewer: ..., Matthias Koeppe