BipartiteGraph.__init__ does not properly initialize for some inputs

[rhinton]

BipartiteGraph.init does not call the base class __init__ for some inputs, leaving the object unusable. For example,

sage: B = BipartiteGraph(None)
sage: B

will throw an exception because the base class attributes have not been initialized. The attached patch ensures the base class __init__ is called.

Component: graph theory

Issue created by migration from https://trac.sagemath.org/ticket/2473

[rlmill]

comment:1

The problem with this approach is it allows one to construct graphs which are not bipartite, but they will be instances of BipartiteGraph. What should be done instead is to raise a NotImplementedError, so that the user knows that the initialization failed. This problem is a small part of the much bigger task in ticket #1941, which is one of the next things I'll be doing. Watch for a patch in the next few days, perhaps...

[rhinton]

Attachment: bipartite_graph_input.patch.gz

try #2

[rhinton]

comment:2

Attachment: bipartite_graph_input.2.patch.gz

The updated patch, I believe, addresses your concerns. It also fixes several more bugs.

[rlmill]

comment:3

Is patch 2 supposed to replace patch 1?

[rlmill]

comment:4

Some notes:

1. "TESTS" should actually be labeled "EXAMPLE" or "EXAMPLES". This is just the convention.

2. Comments in the examples don't need "#"; see many other doctests for examples of the formatting.

3. I've moved the networkx import further down so it only happens if it needs to. This import, if it hasn't been done before, takes several seconds... (I know this doesn't seem to make much sense now, but soon we won't be importing networkx by default whenever we have a graph, so it will make sense eventually.)

[rlmill]

Attachment: 2473-ref.patch.gz

Apply bipartite_graph_input.2.patch, then this.