[with patch, positive review (issues have been addressed)] Wrap Cremona's newforms class

[boothby]

Wrap the newforms class in eclib. Patches will depend upon an updated eclib.

Component: modular forms

Issue created by migration from https://trac.sagemath.org/ticket/2394

[boothby]

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
-Wrap the newforms class in eclib
+Wrap the newforms class in eclib.  Patches will depend upon the updated spkg:
+
+http://sage.math.washington.edu/home/boothby/SPKG/2.10.x/eclib-20080304.spkg

[sagetrac-mabshoff]

comment:4

Three remarks:

• I am splitting the updated eclib.spkg off into its own ticket better parsing for symbolics #2347
• doctests seems to be missing
• It would be interesting to see if this conflicts with wstein's mwrank rewrite

Cheers,

Michael

[sagetrac-mabshoff]

comment:5

I fail to see any difference to eclib-20080127.p0 in the hg log, so can somebody enlighten me what is different?

Cheers,

Michael

[JohnCremona]

comment:6

mabshoff is right -- this is the same as eclib-20080127. I think boothby forgot to check in his changes?

[sagetrac-mabshoff]

comment:7

Yep. Checking the repo I see:

eclib-20080304/src$ hg status
M g0n/Makefile
M g0n/hecketest.cc
M g0n/homspace.cc
M g0n/homspace.h
M g0n/newforms.cc
M g0n/newforms.h
M g0n/nftest.cc
M procs/rat.h
? g0n/ecnf.cc

Cheers,

Michael

[boothby]

Description changed:

--- 
+++ 
@@ -1,3 +1 @@
-Wrap the newforms class in eclib.  Patches will depend upon the updated spkg:
-
-http://sage.math.washington.edu/home/boothby/SPKG/2.10.x/eclib-20080304.spkg
+Wrap the newforms class in eclib.  Patches will depend upon an updated eclib.

[boothby]

comment:8

I didn't change the title of this ticket for a reason! Nothing here is ready for review. The eclib spkg has bad changes, like I made some private class members public, etc. The patch (as noted) doesn't have doctests, and doesn't work. I put this up as a preliminary version for William to work with. Later this week, I'll make it all kosher.