This repository was archived by the owner on Jan 31, 2023. It is now read-only.
GitHub Actions workflow running the patchbot#155
Merged
Conversation
added 7 commits
February 3, 2022 15:51
fchapoton
reviewed
Feb 4, 2022
| patchbot.config['base_branch'])) | ||
| print("Failing tests in your base install: exiting.") | ||
| sys.exit(1) | ||
| print("Warning: Failing tests in your base install.") |
Collaborator
There was a problem hiding this comment.
I do not agree with that. The patchbot must run on a sane ground, and must refuse to run if base has failing doctests. If you want to avoid that, use the existing option "skip-base".
Author
There was a problem hiding this comment.
Would you care to review https://trac.sagemath.org/ticket/33233, which would enable implementing a more flexible solution?
…ests in the base" This reverts commit 30711fd.
Author
|
I've reverted this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be run in a fork of the sage-patchbot repository by selecting the workflow in the Actions tab
Example run: https://github.com/mkoeppe/sage-patchbot/runs/5061999282