Remove FCL deployments and Major Version Bump#107
Merged
dasanra merged 4 commits intosafe-global:remove-fcl-deploymentsfrom Mar 13, 2026
Merged
Remove FCL deployments and Major Version Bump#107dasanra merged 4 commits intosafe-global:remove-fcl-deploymentsfrom
dasanra merged 4 commits intosafe-global:remove-fcl-deploymentsfrom
Conversation
Contributor
|
This is a breaking change, so I would propose one of two things:
|
Collaborator
|
If we are looking for an easier maintenance and we expect we won't need this modules in the future I would go for major version release. |
remedcu
changed the title
Contributor
Author
|
Updated to a major release as per the comments from @dasanra |
dasanra
approved these changes
Mar 13, 2026
dasanra
pushed a commit
that referenced
this pull request
Mar 13, 2026
- There are some known bugs in the FCP `secp256r1` implementation (nothing security-critical ATM). - Also, we no longer need it, especially with EIP-7951. Thus, removing it for now (PR to remove it from `safe-modules` is WIP).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some known bugs in the FCP
secp256r1implementation (nothing security-critical ATM). Also, we no longer need it, especially with EIP-7951. Thus, removing it for now (PR to remove it fromsafe-modulesis WIP).CC @nlordell