fixed issue: Undefined index: plusminus #467 #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
=========================================
Coverage 98.76% 98.76%
- Complexity 1865 1866 +1
=========================================
Files 71 71
Lines 5325 5325
=========================================
Hits 5259 5259
Misses 66 66
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
staabm
approved these changes
Jun 21, 2023
Member
|
could you add a test? |
Contributor
Author
i just added the test. |
Contributor
I don't see any test - let me see if it is easy to write one. |
Member
|
le test: #622 |
phil-davis
approved these changes
Nov 9, 2023
Contributor
I added a short test that failed locally without this fix: So I will merge here, then look at adding the other test. |
This was referenced Nov 9, 2023
Merged
kesselb
added a commit
to nextcloud/3rdparty
that referenced
this pull request
Nov 12, 2023
sabre-io/vobject#619 sabre-io/vobject#623 Signed-off-by: Daniel Kesselberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#467