Quick fix to allow nginx to be installed before another app#3
Merged
ryansmith3136 merged 2 commits intoryansmith3136:masterfrom May 22, 2013
Merged
Quick fix to allow nginx to be installed before another app#3ryansmith3136 merged 2 commits intoryansmith3136:masterfrom
ryansmith3136 merged 2 commits intoryansmith3136:masterfrom
Conversation
- Buildpack-multi only reports the output from the last buildpack, and we want to make sure that the right ruby process types get detected for heroku
ryansmith3136
pushed a commit
that referenced
this pull request
May 22, 2013
* Create bin dir unless it exists * Run the nginx buildpack last
kakutani
referenced
this pull request
in kakutani/nginx-buildpack
Mar 7, 2017
Changed the nginx version and added a status module for additional mo…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the nginx buildpack should run before any other buildpack, since heroku-buildpack-multi outputs the result of the last buildpack to run (as far as I can tell). As such, it looks like we lose some of the configured process types;
heroku run rakefor example won't work unless the version of ruby on the server happens to match the version expect by your app. It should bebundle exec rake, which gets setup by heroku-buildpack-ruby (but only if it's the last buildpack to run).