Modernise React code, fix warnings and fix Travis failure #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format `keywords` and `devDependencies` key. Also commit package-lock.json file.
* Use `babel-preset-env` and `uglify-webpack-plugin` * Set NODE_ENV to 'production' in production * Disable sourcemap in production * Extract css in production
* loaders -> rules * loader -> use
Webpack >2 supports loading json out of the box.
The tests are broken, and xvfb start slows down the builds.
Additionally, remove `no-alert` and `no-console` from .eslintrc because we use that frequently in the code.
Netlify does not like invoking multiple commands.
Refactor deprecated code and upgrade to React v16.3
Run ESLint on script & test directory and fix ESLint warnings.
1. Run script/run-test.sh on Travis. Modify test logic and abandon magic exit code 42. 2. Use npm-run-all instead of parallelshell. Upgrade ava, http-server, webdriver and webpack. 3. Uncomment xvfb start code in .travis.yml. Remove game functionality test code in test/index.js.
Use selenium-standalone instead of webdriver-manager.
Author
|
Travis passes on my fork https://travis-ci.org/li-boxuan/gh-board/builds/402221209?utm_source=email&utm_medium=notification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few commits, including:
Modernise React code and upgrade to v16.3
Update packages
Fix ESLint warnings
Fix Travis failure