feat: add persistent locale throughout the site#699
Closed
shivangrathore wants to merge 1 commit intoruxailab:developfrom
Closed
feat: add persistent locale throughout the site#699shivangrathore wants to merge 1 commit intoruxailab:developfrom
shivangrathore wants to merge 1 commit intoruxailab:developfrom
Conversation
|
Member
|
@shivangrathore, before opening a PR, you should check if the PR related to this feature already exists or not. |
Member
|
@shivangrathore You should close this now. |
Contributor
|
This PR duplicates the work already done in #613, which has already fixed the issue. It is recommended to close this PR to avoid redundancy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This PR Do?
This PR resolves an issue where the locale setting is not persisted between page reloads.
Fixes #698
Changes Made
localeinlocalStorageand retrieve it on page load.localetolocalStoragewhenever it is changed.Reason for Change
The locale setting was being reset on page reload, causing a poor user experience. This change ensures the selected locale is preserved across sessions.
Testing
Manually tested in the development environment. The locale now persists correctly after page reloads.
Before
locale-persist-before-2.mp4
After
locale-persist-after-2.mp4