Update Cargo.toml for target-specific dependencies #3
Conversation
|
This is a breaking change since it requires a recent version of Cargo. |
|
Yes, I tried to do this in Filebuffer too, but it requires a recent version of Rust/Cargo so I reverted it in the end. While this should definitely be done in the future when people have had the time to upgrade, at this point I don’t want to drop support for Rust 1.6 and 1.7 yet. |
|
There's also the issue that regex indirectly depends on thread-id, and regex needs to support Rust 1.3. |
|
I added Rust 1.3 to the Travis CI configuration so we know when something breaks. Though in the case of regex, it could lock the version of thread-id it depends on by adding |
|
Is there anything I can do to help move this forward? I think this is the last dep of ripgrep that pulls in the Windows dependencies on Linux. |
|
The only reason I haven’t done this yet is for compatibility reasons. At the time I was not convinced that a change like this would justify a major version bump because not a single line of Rust code needs to change, but I did not want to break other crates either. But recent events changed my view, so I’ll do a major version bump anyway. I’ll merge this right away. Side note: if you are in a position where you can upgrade to a newer version, you might consider not depending on this library at all in the future, as thread ID support has landed in the standard library recently. |
|
@ruuda Thanks! Thanks for the heads up about the addition to |
|
Unfortunately the thread ID implementation in libstd is not suitable for |
4 participants
Cargo will unnecessarily download and compile windows specific crates (kernel32-sys and its dependencies) on a unix system if target specific dependencies are not specified.